flaneth

make more warnings visible and make them errors, remove warnings
Parent fe468ce
Stefan Schuermans

Stefan Schuermans commited on 2012-05-06 12:00:47
Showing 6 changed files, with 18 additions and 3 deletions.

firmware/Makefile
View file @ 568aa09
... ... 
@@ -96,7 +96,7 @@ EXTRAINCDIRS =
96 96 
 #    -ahlms:  create assembler listing
97 97 
 CFLAGS = -g -O$(OPT) \
98 98 
 -funsigned-char -funsigned-bitfields -fpack-struct -fshort-enums \
99 
--Wall -Wstrict-prototypes \
99 
+-Wall -Wstrict-prototypes -Wextra -Werror \
100 100 
 -Wa,-adhlns=$(<:.c=.lst) \
101 101 
 $(patsubst %,-I%,$(EXTRAINCDIRS)) \
102 102 
 $(DBG_FLAGS)
firmware/cf.c
View file @ 568aa09
... ... 
@@ -488,6 +488,7 @@ char CfIdentify(unsigned long *sectors) // (extern)
488 488 
   }
489 489
490 490 
   debug_cf_printf("CF done (%lu sectors)", CfSectorCnt);
491 
+  *sectors = CfSectorCnt;
491 492
492 493 
   return 0;
493 494 
 }
firmware/debug.h
View file @ 568aa09
... ... 
@@ -31,7 +31,7 @@
31 31 
   do { \
32 32 
     static const PROGMEM char fmt_pgm[] = fmt"\r\n"; \
33 33 
     char fmt_buf[sizeof(fmt_pgm)]; \
34 
-    for(int i = 0; i < sizeof( fmt_pgm ); i++) \
34 
+    for(unsigned int i = 0; i < sizeof( fmt_pgm ); i++) \
35 35 
       fmt_buf[i] = (char)pgm_read_byte_near((uint16_t)fmt_pgm + i); \
36 36 
     printf(fmt_buf, ##arg); \
37 37 
   } while (0)
firmware/dhcp.c
View file @ 568aa09
... ... 
@@ -420,7 +420,7 @@ void DhcpRecv(unsigned char *pData, unsigned short Length)      // (extern)
420 420 
     // get tag and length
421 421 
     tag = *opt_ptr++;
422 422 
     len = *opt_ptr++;
423 
-    if (opt_len < 2 + len)
423 
+    if (opt_len < 2 + (unsigned short)len)
424 424 
       break;
425 425
426 426 
     // get option
firmware/http.c
View file @ 568aa09
... ... 
@@ -399,6 +399,8 @@ unsigned short HttpSend(unsigned char ConnNo, unsigned long Pos,
399 399 
 void HttpSent(unsigned char ConnNo, unsigned long Pos)
400 400 
 {
401 401 
   // nothing needs to be done here
402 
+  (void)ConnNo;
403 
+  (void)Pos;
402 404 
 }
403 405
404 406 
 // called when data was received
firmware/tcp.c
View file @ 568aa09
... ... 
@@ -1155,20 +1155,28 @@ void TcpSend(unsigned char connNo)      // (extern)
1155 1155 
 // dummy notification functions
1156 1156 
 void TcpDummyConnect(unsigned char ConnNo)
1157 1157 
 {
1158 
+  (void)ConnNo;
1158 1159 
 }
1159 1160
1160 1161 
 void TcpDummyClose(unsigned char ConnNo)
1161 1162 
 {
1163 
+  (void)ConnNo;
1162 1164 
 }
1163 1165
1164 1166 
 unsigned short TcpDummySend(unsigned char ConnNo, unsigned long Pos,
1165 1167 
                             unsigned char *pBuffer, unsigned short MaxLen)
1166 1168 
 {
1167 1169 
   return 0;
1170 
+  (void)ConnNo;
1171 
+  (void)Pos;
1172 
+  (void)pBuffer;
1173 
+  (void)MaxLen;
1168 1174 
 }
1169 1175
1170 1176 
 void TcpDummySent(unsigned char ConnNo, unsigned long Pos)
1171 1177 
 {
1178 
+  (void)ConnNo;
1179 
+  (void)Pos;
1172 1180 
 }
1173 1181
1174 1182 
 unsigned short TcpDummyReceived(unsigned char ConnNo, unsigned long Pos,
... ... 
@@ -1176,6 +1184,10 @@ unsigned short TcpDummyReceived(unsigned char ConnNo, unsigned long Pos,
1176 1184 
                                 unsigned short curWnd)
1177 1185 
 {
1178 1186 
   return max(curWnd, 128);
1187 
+  (void)ConnNo;
1188 
+  (void)Pos;
1189 
+  (void)pBuffer;
1190 
+  (void)Len;
1179 1191 
 }
1180 1192
1181 1193 
 struct TcpNotify TcpDummyNotify =       // (extern)
1182 1194