BlinkenLib

@@ -17,7 +17,6 @@ static int serial_settings_parse(char *str)

 {

   int baud, data, stop;

   char parity;

-  int set = 0;

   // split and parse settings string

   if (sscanf(str, "%i,%c,%i,%i", &baud, &parity, &data, &stop) != 4)

@@ -62,15 +61,16 @@ static int serial_settings_set(HANDLE hDev, char *settings)

   // set serial parameters

   if (!GetCommState(hDev, &PortDcb)) {

-    printf("error getting device comm state: error %u\n", GetLastError());

+    printf("error getting device comm state: error %lu\n", GetLastError());

     return 0;

   }

   if (!BuildCommDCB(hDev, &PortDcb)) {

-    printf("error building comm state: error %u\n", GetLastError());

+    printf("error building comm state: error %lu\n", GetLastError());

     return 0;

   }

+  (void) settings; // TODO: set PortDcb fields

   if (!SetCommState(hDev, &PortDcb)) {

-    printf("error setting device comm state: error %u\n", GetLastError());

+    printf("error setting device comm state: error %lu\n", GetLastError());

     return 0;

   }

   // set timeout parameters

@@ -85,7 +85,7 @@ static int serial_settings_set(HANDLE hDev, char *settings)

   CommTimeouts.WriteTotalTimeoutConstant = 0;

   CommTimeouts.WriteTotalTimeoutMultiplier = 0;

   if (!SetCommTimeouts(hDev, &CommTimeouts)) {

-    printf("error setting device timeout parameters: error %u\n",

+    printf("error setting device timeout parameters: error %lu\n",

            GetLastError());

     return 0;

   }

@@ -108,12 +108,11 @@ static int recv_and_out(SOCKET udpSocket, HANDLE hDev,

   fd_set readFds, errFds;

   stBlinkenFrame *pFrame;

   char buffer[65536];   // 64kB is more than maximum UDP size

-  int len, dev_eof;

+  int len;

   struct timeval timeout, *p_timeout;

   DWORD DevWrLen, Err, start, end;

   COMSTAT ComStat;

-  dev_eof = 0;

   for (;;) {

     // wait for next frame

     FD_ZERO(&readFds);

@@ -184,7 +183,7 @@ static int recv_and_out(SOCKET udpSocket, HANDLE hDev,

       // reception error

       if (Err & (CE_BREAK | CE_FRAME | CE_OVERRUN | CE_RXOVER | CE_RXPARITY)) {

         if (*p_device_output_active)

-          printf("error reading from device (comm err=%X)\n", Err);

+          printf("error reading from device (comm err=%lX)\n", Err);

         break;

       }

     }

@@ -225,7 +224,7 @@ static int open_and_output(SOCKET udpSocket, char *device,

                  0, NULL);

   if (hDev == INVALID_HANDLE_VALUE) {

     if (*p_device_output_active)

-      printf("could not open \"%s\": error %u\n", device, GetLastError());

+      printf("could not open \"%s\": error %lu\n", device, GetLastError());

     return 0;

   }

   // setup serial port

@@ -311,7 +310,8 @@ int main(int argCnt, char **args)

   unsigned int format_change, format_height, format_width, format_channels,

       format_colors;

   unsigned int height, width, channels, colors, reopen_device_ms;

-  int serial_settings_change, reopen_device, unblock;

+  int serial_settings_change, reopen_device;

+  unsigned long unblock;

   char txt[64];

   unsigned short port;

   struct sockaddr_in addr;

@@ -351,7 +351,7 @@ int main(int argCnt, char **args)

   // create udp socket

   udpSocket = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP);

   if (udpSocket == INVALID_SOCKET) {

-    printf("cannot create UDP socket: error %lu\n", WSAGetLastError());

+    printf("cannot create UDP socket: error %u\n", WSAGetLastError());

     WSACleanup();

     return -1;

   }

@@ -360,7 +360,7 @@ int main(int argCnt, char **args)

   // unblock udp socket

   unblock = 1;

   if (ioctlsocket(udpSocket, FIONBIO, &unblock) == SOCKET_ERROR) {

-    printf("cannot unblock UDP socket: error %lu\n", WSAGetLastError());

+    printf("cannot unblock UDP socket: error %u\n", WSAGetLastError());

     closesocket(udpSocket);

     WSACleanup();

     return -1;